From 5a0bd853309f30a2e1583459728df9725b1e2664 Mon Sep 17 00:00:00 2001
From: Dean Camera <dean@fourwalledcubicle.com>
Date: Thu, 26 Jul 2012 19:16:58 +0000
Subject: [PATCH] Fix errors in some board driver LED_Disable() functions.
---
LUFA/Drivers/Board/AVR8/BIGMULTIO/LEDs.h | 4 ++--
LUFA/Drivers/Board/AVR8/MULTIO/LEDs.h | 4 ++--
LUFA/Drivers/Board/AVR8/OLIMEX32U4/LEDs.h | 6 +++---
LUFA/Drivers/Board/AVR8/OLIMEXT32U4/LEDs.h | 6 +++---
4 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/LUFA/Drivers/Board/AVR8/BIGMULTIO/LEDs.h b/LUFA/Drivers/Board/AVR8/BIGMULTIO/LEDs.h
index bafedcca3..e696aea5a 100644
--- a/LUFA/Drivers/Board/AVR8/BIGMULTIO/LEDs.h
+++ b/LUFA/Drivers/Board/AVR8/BIGMULTIO/LEDs.h
@@ -105,8 +105,8 @@
static inline void LEDs_Disable(void)
{
- DDRF |= LEDS_PORTF_LEDS;
- DDRE |= LEDS_PORTE_LEDS;
+ DDRF &= ~LEDS_PORTF_LEDS;
+ DDRE &= ~LEDS_PORTE_LEDS;
PORTF &= ~LEDS_PORTF_LEDS;
PORTE &= ~LEDS_PORTE_LEDS;
diff --git a/LUFA/Drivers/Board/AVR8/MULTIO/LEDs.h b/LUFA/Drivers/Board/AVR8/MULTIO/LEDs.h
index 14809df28..03506b4c2 100644
--- a/LUFA/Drivers/Board/AVR8/MULTIO/LEDs.h
+++ b/LUFA/Drivers/Board/AVR8/MULTIO/LEDs.h
@@ -105,8 +105,8 @@
static inline void LEDs_Disable(void)
{
- DDRD |= LEDS_PORTD_LEDS;
- DDRC |= LEDS_PORTC_LEDS;
+ DDRD &= ~LEDS_PORTD_LEDS;
+ DDRC &= ~LEDS_PORTC_LEDS;
PORTD &= ~LEDS_PORTD_LEDS;
PORTC &= ~LEDS_PORTC_LEDS;
diff --git a/LUFA/Drivers/Board/AVR8/OLIMEX32U4/LEDs.h b/LUFA/Drivers/Board/AVR8/OLIMEX32U4/LEDs.h
index 62b7c7829..6f5591e7c 100644
--- a/LUFA/Drivers/Board/AVR8/OLIMEX32U4/LEDs.h
+++ b/LUFA/Drivers/Board/AVR8/OLIMEX32U4/LEDs.h
@@ -113,11 +113,11 @@
static inline void LEDs_Disable(void)
{
- DDRB &= LEDS_PORTB_LEDS;
+ DDRB &= ~LEDS_PORTB_LEDS;
PORTB &= ~LEDS_PORTB_LEDS;
- DDRD &= (LEDS_PORTD_LEDS << LEDS_PORTD_MASK_SHIFT);
+ DDRD &= ~(LEDS_PORTD_LEDS << LEDS_PORTD_MASK_SHIFT);
PORTD &= ~(LEDS_PORTD_LEDS << LEDS_PORTD_MASK_SHIFT);
- DDRE &= LEDS_PORTE_LEDS;
+ DDRE &= ~LEDS_PORTE_LEDS;
PORTE &= ~LEDS_PORTE_LEDS;
}
diff --git a/LUFA/Drivers/Board/AVR8/OLIMEXT32U4/LEDs.h b/LUFA/Drivers/Board/AVR8/OLIMEXT32U4/LEDs.h
index 1602af842..d1d19093e 100644
--- a/LUFA/Drivers/Board/AVR8/OLIMEXT32U4/LEDs.h
+++ b/LUFA/Drivers/Board/AVR8/OLIMEXT32U4/LEDs.h
@@ -107,11 +107,11 @@
static inline void LEDs_Disable(void)
{
- DDRB &= LEDS_PORTB_LEDS;
+ DDRB &= ~LEDS_PORTB_LEDS;
PORTB &= ~LEDS_PORTB_LEDS;
- DDRD &= LEDS_PORTD_LEDS;
+ DDRD &= ~LEDS_PORTD_LEDS;
PORTD &= ~LEDS_PORTD_LEDS;
- DDRE &= LEDS_PORTE_LEDS;
+ DDRE &= ~LEDS_PORTE_LEDS;
PORTE &= ~LEDS_PORTE_LEDS;
}
--
GitLab