From 67cb070810bd3122491fb6c1c1bf921bf89bde31 Mon Sep 17 00:00:00 2001
From: Dean Camera <dean@fourwalledcubicle.com>
Date: Sun, 14 Feb 2010 22:13:11 +0000
Subject: [PATCH] Fix HID Host Class driver sending incorrect ReportType values
to the device when issuing requests via the control pipe.
---
LUFA/Drivers/USB/Class/Host/HID.c | 4 ++--
LUFA/ManPages/LUFAPoweredProjects.txt | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/LUFA/Drivers/USB/Class/Host/HID.c b/LUFA/Drivers/USB/Class/Host/HID.c
index 1e1dbcff6..b95f73c73 100644
--- a/LUFA/Drivers/USB/Class/Host/HID.c
+++ b/LUFA/Drivers/USB/Class/Host/HID.c
@@ -159,7 +159,7 @@ uint8_t HID_Host_ReceiveReportByID(USB_ClassInfo_HID_Host_t* const HIDInterfaceI
{
.bmRequestType = (REQDIR_HOSTTODEVICE | REQTYPE_CLASS | REQREC_INTERFACE),
.bRequest = REQ_SetReport,
- .wValue = (REPORT_ITEM_TYPE_In << 8) | ReportID,
+ .wValue = ((REPORT_ITEM_TYPE_In + 1) << 8) | ReportID,
.wIndex = HIDInterfaceInfo->State.InterfaceNumber,
.wLength = USB_GetHIDReportSize(HIDInterfaceInfo->Config.HIDParserData, ReportID, REPORT_ITEM_TYPE_In),
};
@@ -246,7 +246,7 @@ uint8_t HID_Host_SendReportByID(USB_ClassInfo_HID_Host_t* const HIDInterfaceInfo
.bmRequestType = (REQDIR_HOSTTODEVICE | REQTYPE_CLASS | REQREC_INTERFACE),
.bRequest = REQ_SetReport,
#if !defined(HID_HOST_BOOT_PROTOCOL_ONLY)
- .wValue = (REPORT_ITEM_TYPE_Out << 8) | ReportID,
+ .wValue = ((REPORT_ITEM_TYPE_Out + 1) << 8) | ReportID,
#else
.wValue = 0,
#endif
diff --git a/LUFA/ManPages/LUFAPoweredProjects.txt b/LUFA/ManPages/LUFAPoweredProjects.txt
index 454962ae9..b03b9083d 100644
--- a/LUFA/ManPages/LUFAPoweredProjects.txt
+++ b/LUFA/ManPages/LUFAPoweredProjects.txt
@@ -73,5 +73,5 @@
* \section Sec_LUFAPublications Publications Mentioning LUFA
* - Elektor Magazine, "My First AVR-USB" by Antoine Authier (feature), January 2010 Issue
* - Elektor Magazine, "USB is Cool/Sucks" by Jerry Jacobs and Chris Vossen (minor mention), January 2010 Issue
- * - Elektor Magazine, "20 x Open Source", March 2010 Issue
+ * - Elektor Magazine, "20 x Open Source" by Jens Nickel, March 2010 Issue
*/
\ No newline at end of file
--
GitLab