From 174ba2dad05704a1343e7d10c0798f151e29e41a Mon Sep 17 00:00:00 2001
From: Erik Strand <erik.strand@cba.mit.edu>
Date: Fri, 17 Apr 2020 13:30:06 -0400
Subject: [PATCH] Add TODOs for rvalue references for cma-es and gd
---
optimization/optimizers/cma_es/cma_es.h | 1 +
optimization/optimizers/gradient_descent/gradient_descent.h | 1 +
2 files changed, 2 insertions(+)
diff --git a/optimization/optimizers/cma_es/cma_es.h b/optimization/optimizers/cma_es/cma_es.h
index 7cdfa00..4994c35 100644
--- a/optimization/optimizers/cma_es/cma_es.h
+++ b/optimization/optimizers/cma_es/cma_es.h
@@ -35,6 +35,7 @@ public:
inline Eigen::Map<const Eigen::MatrixXd> point();
Scalar value() { return cmaes_Get(&cma_es_, "fbestever"); }
+ // TODO: Support passing initial point by rvalue reference.
template <typename Objective>
Eigen::Map<const Eigen::MatrixXd> optimize(
Objective& objective,
diff --git a/optimization/optimizers/gradient_descent/gradient_descent.h b/optimization/optimizers/gradient_descent/gradient_descent.h
index e8a7bf6..77968c3 100644
--- a/optimization/optimizers/gradient_descent/gradient_descent.h
+++ b/optimization/optimizers/gradient_descent/gradient_descent.h
@@ -25,6 +25,7 @@ public:
VectorNs<N> const& gradient() const { return gradient_; }
Scalar value() const { return value_; }
+ // TODO: Support passing initial point by rvalue reference.
template <typename Objective>
VectorNs<N> const& optimize(Objective& objective, VectorNs<N> const& initial_point);
--
GitLab